[Adium-devl] rev 20150 - branches/adium-1.0/Release
Juan Manuel Palacios
jmpp at macports.org
Wed Jul 11 05:15:20 UTC 2007
On Jul 10, 2007, at 7:13 PM, Evan Schoenberg wrote:
> On Jul 10, 2007, at 10:16 AM, Juan Manuel Palacios wrote:
>> One more question though, since you practically greenlight'd me
>> to do it ;-) In r20164 you do this right under the variables
>> section in trunk/Release/Makefile:
>> +ifeq ($(BETA),TRUE)
>> + BUILDFLAGS="$(BUILDFLAGS) CFLAGS=-DBETA_RELEASE"
>> Shouldn't we be appending to the CFLAGS there? That is, shouldn't
>> we instead do CFLAGS += -DBETA_RELEASE? Otherwise we would be
>> completely overriding the inherited cflags, if any. Maybe there
>> aren't any prior to that, but I'd say it's always safe not
>> overriding such an important environment variable. Just my two
>> cents ;-)
> I'm a *total* newb in the world of Makefiles. Could you put a
> patch together doing your improvement, such that -DBETA_RELEASE is
> in the CFLAGS for when BETA is true?
> Note: The Makefile in question is in adium/Releases/, and it calls
> make on the Makefile in adium/. It was this passing around of
> variables which made me think I had to do something awkward, but
> that's most likely just ignorance talking.
I'd love to take a stab at it and see what I can improve, time
allowing I'll send you a patch with my suggestions. I aint neither
the best one out there in Makefiles, but I believe looking and
mocking with some of the many Makefiles we have in MacPorts and
wondering for hours why certain things fail (or, even worse, how they
work!) has taught me a bit ;-)
Hope to get back to you soon with results! Regards,...
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Adium-devl